BigQuery: Add to_standard_sql() method to SchemaField #8880
Conversation
googlebot
added
the
cla: yes
|
|
||
| # NOTE: No need to also handle the "ARRAY" composed type, the latter | ||
| # does not exist in legacy SQL types. | ||
| if sql_type.type_kind == types.StandardSqlDataType.STRUCT: # noqa: E721 |
There was a problem hiding this comment.
False positive here, flake8 thinks that is about comparing types and wants to enforce isinstance() - but that would not work, as we actually compare integers here.
|
Support for standard SQL type names and simple arrays added. Still need to add support for arrays containing STRUCTs, do not merge yet. |
|
@tswast You mean sharing the conversion logic or the test for it? Since the "target results" differ, there are differences between the two implementations, and they are both reasonably short, too, thus we might not actually gain that much by refactoring. (but of course, if you see something "obvious" that would represent a good opportunity, we can add this improvement in another PR) |
|
Agreed. Not obvious to me right now how to share code without it getting more complex. |
Closes #8494.
This PR adds a method to convert a legacy table field instance to the new
StandardSqlFieldtype.How to test
Verify that the types are correctly mapped from the legacy to standard SQL, and that the new method does what it is supposed to do.